Skip to content

MQTT: disconnect consumer when queue is deleted (backport #13996) #14013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 3, 2025
Merged

MQTT: disconnect consumer when queue is deleted (backport #13996) #14013

merged 6 commits into from
Jun 3, 2025

Conversation

@mergify
Copy link

@mergify mergify bot commented Jun 3, 2025

Queues are automatically declared for MQTT consumers, but they can be externally deleted. The consumer should be disconnected in such case, because it has no way of knowing this happened - from its perspective there are simply no messages to consume.

In RabbitMQ 3.11 the consumer was disconnected in such situation. This behaviour changed with native MQTT, which doesn't use AMQP internally.

Fixes #13785

This is an automatic backport of pull request #13996 done by [Mergify](https://mergify.com).

dcorbacho and others added 5 commits June 3, 2025 04:51
@dcorbacho @mergify
MQTT: disconnect consumer when queue is deleted
8ba2b41 
Queues are automatically declared for MQTT consumers, but they can be externally
deleted. The consumer should be disconnected in such case, because it has no way
of knowing this happened - from its perspective there are simply no messages to consume.

In RabbitMQ 3.11 the consumer was disconnected in such situation.
This behaviour changed with native MQTT, which doesn't use AMQP internally.

(cherry picked from commit bf468bd)

# Conflicts:
#	deps/rabbitmq_mqtt/test/mqtt_shared_SUITE.erl
@michaelklishin @mergify
web_mqtt: propagate notify_consumer_classic_queue_deleted to mqtt_sha…
30854bb 
…red_SUITE

(cherry picked from commit 9eaa220)
@dcorbacho @mergify
web_mqtt: propagate notify_consumer_quorum/qos0_queue_deleted to mqtt…
7490a99 
…_shared_SUITE

(cherry picked from commit d91c9d6)
@dcorbacho @mergify
REVERT try ubuntu 22.04
c1e1023 
(cherry picked from commit 610c838)
@michaelklishin @mergify
Revert "REVERT try ubuntu 22.04"
22f8657 
This reverts commit 5a02604.

(cherry picked from commit b48ab72)
@mergify mergify bot added the conflicts label Jun 3, 2025
@mergify
Copy link
Author

mergify bot commented Jun 3, 2025

Cherry-pick of bf468bd has failed:

On branch mergify/bp/v4.1.x/pr-13996
Your branch is up to date with 'origin/v4.1.x'.

You are currently cherry-picking commit bf468bdd5.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   deps/rabbitmq_mqtt/src/rabbit_mqtt_processor.erl
	modified:   deps/rabbitmq_mqtt/src/rabbit_mqtt_qos0_queue.erl
	modified:   deps/rabbitmq_mqtt/src/rabbit_mqtt_reader.erl

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   deps/rabbitmq_mqtt/test/mqtt_shared_SUITE.erl

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@michaelklishin michaelklishin merged commit a8e1ee4 into v4.1.x Jun 3, 2025
273 checks passed
@michaelklishin michaelklishin deleted the mergify/bp/v4.1.x/pr-13996 branch June 3, 2025 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@dcorbacho dcorbacho

Labels

conflicts

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@michaelklishin @dcorbacho